Conversation

• I Indiekit Demo Indiekit Demo remote 4 days ago You are here

  🐛 Issue #994 — Frontend components drop the upload, find location and tag input set-up on main

  Issue ouverte · Issue #994 Frontend components drop the upload, find location and tag input set-up on main · @rmdes

  Since 691b359, component lookups throw when an element is missing. Four lookups are of elements that are absent by design, each followed by a null check the throw now makes unreachable:

  • file-input/index.js:48 and geo-input/index.js:30: the picker and the button live only in a <template> until connectedCallback clones them in.
  • tag-input/index.js:7-8: a hint and an error message are only rendered when given.
  • textarea/index.js:171: the status bar can be turned off with editor-status="false".

  The throw aborts connectedCallback, so on main the upload button next to photo, video, audio and featured URL fields, the find location button, and the category tag input are never set up. Nothing is lost (the URL fields and the editor’s own image upload still work), but those three are missing.

  Reproduction: open /posts/create?type=photo. There is no “Upload file” button next to the photo URL field, and the console shows No element matching .file-input__picker, No element matching .geo-input__button and No element matching .error-message.

  

  Ouvrir sur GitHub →

  
  source