Conversation

• I Indiekit Demo Indiekit Demo remote 4 days ago You are here

  🟢 PR #997 — feat(frontend): choose an existing media file from the editor and file fields

  Pull request (OPEN) · PR #997 feat(frontend): choose an existing media file from the editor and file fields · @rmdes

  Fixes #996

  Adds a “Browse media…” button to the editor toolbar and to the file input. It opens a <dialog> listing files from the media endpoint (q=source, with “Show more” following paging.after). Choosing a file inserts ![](url) for a photo or [filename](url) otherwise in the editor, or fills the file input’s path.

  • The dialog markup and strings come from a <template> rendered by the component, so they are localised; the new mediaBrowser keys are in every frontend locale.
  • The editor button shows wherever the editor has a toolbar and a media endpoint, not only where image upload is enabled, so notes get it too. Plain text fields like an article’s summary are unchanged.
  • One new toolbar icon (browse-media), alongside the existing ones.
  • Tests: test/unit/utils/media-browser.js covers listing, choosing, paging, the empty and error messages, and cancelling.

  Tested on the quickstart stack with an image built from this branch, in English and French: the photo field, and the article, note and photo content editors.

  Ouvrir sur GitHub →

  source