Commentaire de pull request · PR #960 build: official container image with release, nightly and preview channels · @rmdes
Dropping the nightly. That leaves release (on release: published) and the manual preview, and docker-nightly.yml goes with it — one file plus its row in the docs table.
On lerna and husky: they were yours, both on 2022-03-25, c5c1e3d4 "ci: make lerna a dependency" and 91757e2f "ci: make husky a dependency".
They started in devDependencies (1bf21d91, e0356738) and moved that day — the same day as 44e484de "ci: make lerna play nice with workspaces", which set useWorkspaces: true. So it looks like fallout from the npm-workspaces migration rather than a runtime need.
As far as I can tell the reason no longer holds. postinstall is husky, and publish.yml installs with npm ci --ignore-scripts, so it never runs there; build.yml and deploy.yml run a plain npm ci, which installs devDependencies anyway. lerna is only invoked as npx lerna publish in that same job, where a dev dependency would resolve. I haven’t tried moving them back, so treat that as a reading of the files rather than a tested claim.
Out of scope for this PR either way — the image uses --ignore-scripts, so the only cost is the two packages riding along. Happy to open a separate PR if you want them moved.